fix(npm): remove --unsafe-perm flag from install scripts - #7953
Open
aholten wants to merge 1 commit into
Open
Conversation
npm 12 rejects unknown CLI flags, so the npm install path crashes with EUNKNOWNCONFIG before installing. The flag has been a no-op since npm 7; remove it from install.sh and the postinstall guard. Closes coder#7950.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7950. Removes the --unsafe-perm flag from the three sites that pass or require it: npm 12 rejects unknown CLI flags (EUNKNOWNCONFIG) so the install dies before starting. The flag has been behaviorally irrelevant since npm v7.0.0 (2020): the changelog says the user/group/uid/gid/unsafe-perms configs are 'no longer relevant.' Scripts run as the working-dir owner regardless.
Changes
2 files: install.sh (drop flag from global install) + ci/build/npm-postinstall.sh (remove root guard that errors unless unsafe_perm=true, drop flag from dev-install). Validation: grep zero unsafe-perm refs, bash -n syntax OK, npm run test:scripts 34/34 pass.
Repro
before: npm 12 + install -g code-server --unsafe-perm -> EUNKNOWNCONFIG. Follow-up tracked separately: npm 12 blocks postinstall scripts unless --allow-scripts is configured.